Remove the temporary caching feature flag #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
reviewed
Nov 21, 2023
mountpoint-s3/CHANGELOG.md
Outdated
| * No breaking changes. | ||
|
|
||
| ### Other changes | ||
| * Introduced the `--cache` option to configure Mountpoint to cache object metadata and content, in order to reduce cost and improve performance for repeated reads to the same files. ([#622](https://github.com/awslabs/mountpoint-s3/pull/622)) |
There was a problem hiding this comment.
I think this is a bit understated. Should it be under something like ### New features?
In terms of the text, maybe something like:
### New features
Introduced optional caching of object metadata and content,
in order to allow reduced cost and improved performance for repeated reads to the same files.
([#622](https://github.com/awslabs/mountpoint-s3/pull/622))
I'm also thinking when we merge the documentation, we can follow up too:
### New features
Introduced optional caching of object metadata and content,
in order to allow reduced cost and improved performance for repeated reads to the same files.
To get started, see the [caching section of the configuration documentation](https://github.com/awslabs/mountpoint-s3/blob/main/doc/CONFIGURATION.md#caching-configuration).
([#622](https://github.com/awslabs/mountpoint-s3/pull/622))
There was a problem hiding this comment.
@jamesbornholt can you share feedback here too?
There was a problem hiding this comment.
agree we should put this in a new features section
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>
passaro
force-pushed
the
caching-feature
branch
from
62fb41f to
4eb5fb0
Compare
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
|
Adopted @dannycjones suggestions and rebased to solve conflicts with |
dannycjones
approved these changes
Nov 21, 2023
jamesbornholt
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Remove the "caching" build feature. With this change, the new command line flag
--cacheand related options to support caching are generally available.Relevant issues: #255
Does this change impact existing behavior?
No. The new caching behavior is optional and needs to be explicitly enabled with a command line flag.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).