-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs clarifications about which FS operations can be served from cache and when #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 12:14 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 12:14 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 12:14 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 12:14 — with
GitHub Actions
Inactive
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 16:44 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 16:44 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 16:44 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 16:44 — with
GitHub Actions
Inactive
dannycjones
changed the title
Add docs clarification about which FS operations can be served from cache
Add docs clarifications about which FS operations can be served from cache and when
Nov 23, 2023
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 17:42 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 17:42 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 17:42 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
November 23, 2023 17:42 — with
GitHub Actions
Inactive
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
temporarily deployed
to
PR integration tests
December 4, 2023 11:37 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 4, 2023 11:37 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 4, 2023 11:37 — with
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
December 4, 2023 11:37 — with
GitHub Actions
Inactive
jamesbornholt
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The documentation today isn't clear about which operations users should expect to be served from cache, and which are still expected to go to S3.
Adding some short changes to avoid any confusion on this.
Relevant issues: #255
Does this change impact existing behavior?
No breaking change, docs change only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).