Rename docs_rs config condition to docsrs #956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change is made to avoid config condition errors now that check config is run by default in Rust 1.80+.
Without this change, compilation will fail like below:
Rather than specifying the
docs_rs
config condition in our Cargo.toml, we can use the one already existing and documented by docs.rs: https://docs.rs/about/builds#detecting-docsrsThis change removes the setting of
docs_rs
cfg condition and updates all conditions to use the existing condition set by docs.rs.Checked using the following command that the docs aren't a mess by looking at
mountpoint_s3_client::object_client::PutObjectRequest
:Fixes CI issue blocking PR #949.
Relevant issues: N/A
Does this change impact existing behavior?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).