Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unneeded SetIntPoint calls for Coefficient evaluation #105

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

sebastiangrimberg
Copy link
Contributor

An mfem::ElementTransformation is configured at the given integration point in the loop over quadrature points inside of the element, at the level of a Linear/BilinearForm assembly or GridFunction evaluation. Calling SetIntPoint again will reset the transformation and require redundant computation of the element Jacobian in cases where it could have been reused.

@sebastiangrimberg sebastiangrimberg added minor A minor issue or improvement performance Related to performance labels Oct 12, 2023
palace/fem/coefficient.hpp Outdated Show resolved Hide resolved
@sebastiangrimberg sebastiangrimberg merged commit d55abfa into main Oct 12, 2023
17 checks passed
@sebastiangrimberg sebastiangrimberg deleted the sjg/coeff-ip-opt branch October 12, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor A minor issue or improvement performance Related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants