Build system updates #151
Merged
Build system updates #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sebastiangrimberg
commented
Dec 13, 2023
•
sebastiangrimberg
commented
- Update MFEM and libCEED dependencies
- Update all other dependency versions
- Forward linker flags to dependency builds
- Miscellaneous updates in preparation for GPU builds (Configure and pass GPU options to dependencies, add Slate and MAGMA dependencies for GPU builds, Hypre use GNU Make build system instead of CMake for HIP support)
sebastiangrimberg
force-pushed
the
sjg/build-system-updates
branch
2 times, most recently
from
036e6fb to
7c34cce
Compare
sebastiangrimberg
force-pushed
the
sjg/build-system-updates
branch
from
7c34cce to
a369a6a
Compare
sebastiangrimberg
force-pushed
the
sjg/build-system-updates
branch
from
a369a6a to
6575381
Compare
sebastiangrimberg
force-pushed
the
sjg/build-system-updates
branch
from
6575381 to
0f520fb
Compare
|
This PR goes alongside the documentation updates in #146 (mainly the updated CMake requirement to v3.21, for upcoming HIP support). |
hughcars
approved these changes
Dec 20, 2023
| set(LIBCEED_OPT_FLAGS "${LIBCEED_OPT_FLAGS} -isystem ${CUDA_DIR}/include") | ||
| endif() | ||
| if(PALACE_WITH_HIP) | ||
| set(LIBCEED_OPT_FLAGS "${LIBCEED_OPT_FLAGS} -isystem ${ROCM_DIR}/include") |
There was a problem hiding this comment.
ROCM_DIR? Just pattern matching here relative to CUDA_DIR above.
There was a problem hiding this comment.
Yeah, using the same naming as https://github.com/CEED/libCEED/blob/main/Makefile. The missing piece that will come with GPU builds (along with the PALACE_WITH_CUDA and PALACE_WITH_HIP options) is to define CUDA_DIR and ROCM_DIR based on the paths located by CMake.
sebastiangrimberg
added a commit
that referenced
this pull request
Dec 20, 2023
sebastiangrimberg
added a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.