-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit multigrid operator construction and full-assembly #167
Conversation
5c3d59b
to
37672e3
Compare
a0071e2
to
44bb7af
Compare
37672e3
to
f17ab7d
Compare
44bb7af
to
fba6b59
Compare
fba6b59
to
6a5574b
Compare
1905d0b
to
7ac1abc
Compare
6a5574b
to
e321258
Compare
7ac1abc
to
776ce39
Compare
e321258
to
b04a669
Compare
…tor::Mult methods
b04a669
to
8ec1ad4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tried to think of a simpler control flow for the PtAPr/i
and hr/i
section but most just end up in more of a mess so I think the mild complexity there is totally valid.
constexpr bool skip_zeros = false; | ||
BilinearForm m(h1_fespaces.GetFinestFESpace()); | ||
m.AddDomainIntegrator<DiffusionIntegrator>(epsilon_func); | ||
// m.AssembleQuadratureData(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debris?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to leave these in (as with #167 (comment)) in case eventually we do want to activate this (though for now it does appear to not be worth the extra memory overhead).
NOTE: Based on #166
Summary of changes:
MfemWrapperSolver
.