Testing (do not merge): Turn on operator partial assembly by default

CHANGELOG.md

@@ -13,6 +13,9 @@ The format of this changelog is based on
 
 ## In progress
 
+  - Changed default value of `config["Solver"]["PartialAssemblyOrder"]` in order to active
+    operator partial assembly by default for all operators in all simulation types.
+
 ## [0.12.0] - 2023-12-21
 
   - Added support for operator partial assembly for high-order finite element spaces based

docs/src/config/solver.md

@@ -43,9 +43,11 @@ with
 
 `"Order" [1]` :  Finite element order (degree). Arbitrary high-order spaces are supported.
 
-`"PartialAssemblyOrder" [100]` :  Order at which to switch from full assembly of finite
+`"PartialAssemblyOrder" [1]` :  Order at which to switch from full assembly of finite
 element operators to [partial assembly](https://mfem.org/howto/assembly_levels/). Setting
-this parameter equal to 1 will fully activate operator partial assembly on all levels.
+this parameter equal to 1 will fully activate operator partial assembly on all levels, while
+setting it to some large number (greater than the finite element order) will result in
+fully assembled operators as sparse matrices.
 
 `"Device" ["CPU"]` :  The runtime device configuration passed to
 [MFEM](https://mfem.org/howto/assembly_levels/) in order to activate different options

palace/utils/configfile.hpp

@@ -873,7 +873,7 @@ struct SolverData
   int order = 1;
 
   // Order above which to use partial assembly instead of full assembly.
-  int pa_order_threshold = 100;
+  int pa_order_threshold = 1;
 
   // Include the order of det(J) in the order of accuracy for quadrature rule selection.
   bool q_order_jac = false;

palace/utils/iodata.cpp

@@ -323,9 +323,6 @@ void IoData::CheckConfiguration()
     }
   }
 
-  // XX TODO: Default value for pa_order_threshold if we want PA enabled by default
-  // XX TODO: Enable Device::GPU by default if MFEM built with CUDA/HIP support?
-
   // Resolve default values in configuration file.
   if (solver.linear.type == config::LinearSolverData::Type::DEFAULT)
   {