Bugfix: Coefficient for empty attr_list
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
#166 introduced an issue where coefficients with matching attribute lists, might have different size K, if all the attributes are
-1. This is a consequence of these lines where a coefficient goes from size zero to size 1, even if there were no local attributes associated. This triggers these lines ifattr_matis all -1, but the incoming coefficient is of size zero. This can occur if one rank does not have any piece of the relevant geometry. The fix is ifattr_listis entry in adding a coefficient, to do nothing.