Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade error estimation for time-dependent problems #233

Merged
merged 12 commits into from
May 9, 2024

Conversation

sebastiangrimberg
Copy link
Contributor

@sebastiangrimberg sebastiangrimberg commented Apr 19, 2024

Consider both electric flux density and magnetic field recovery error for transient problems. Note: The improved recovery is incorrect for "infinitely thin" interior boundaries applying a PEC or impedance BC. In this case these BCs break the continuity of the recovered H and D fields. This will be resolved in a future PR and is a separate improvement to the changes here.

TODO

  • Changelog
  • Rebaseline error indicators in (time dependent) examples

Note: Based on #237

@sebastiangrimberg sebastiangrimberg added enhancement New feature or request amr Related to adaptive mesh refinement (AMR) labels Apr 19, 2024
@sebastiangrimberg
Copy link
Contributor Author

Visualizations of the error indicator for the CPW example with lumped ports, at 60 GHz (to show the effect of multiple wavelengths):

  • E-field magnitude at time = 0

Screenshot 2024-04-19 at 2 04 32 PM

  • main:

Screenshot 2024-04-19 at 2 02 16 PM

  • This PR:

Screenshot 2024-04-19 at 2 02 04 PM

We see that the correction for both energy terms (kinetic + potential, or magnetic + electric fields) makes the indicator more uniform over the length of the transmission line as we might expect, instead of preferentially indicating high errors at nodes of the electric field.

@sebastiangrimberg sebastiangrimberg marked this pull request as ready for review April 19, 2024 21:25
@sebastiangrimberg sebastiangrimberg force-pushed the sjg/error-estimator-dev branch 3 times, most recently from a5aafac to bb5b6a0 Compare April 24, 2024 15:57
@sebastiangrimberg sebastiangrimberg changed the base branch from sjg/error-estimator-dev-prep to sjg/cap-matrix-opt April 24, 2024 16:39
@sebastiangrimberg sebastiangrimberg force-pushed the sjg/error-estimator-dev branch from bb5b6a0 to 436be1e Compare April 24, 2024 22:46
@sebastiangrimberg sebastiangrimberg force-pushed the sjg/error-estimator-dev branch from 04c9a40 to 8af134d Compare April 30, 2024 21:56
@sebastiangrimberg sebastiangrimberg force-pushed the sjg/error-estimator-dev branch 2 times, most recently from c7915cc to c358bbc Compare May 1, 2024 21:01
@sebastiangrimberg sebastiangrimberg requested a review from hughcars May 6, 2024 15:43
CHANGELOG.md Outdated Show resolved Hide resolved
palace/linalg/errorestimator.hpp Outdated Show resolved Hide resolved
palace/linalg/densematrix.cpp Outdated Show resolved Hide resolved
Base automatically changed from sjg/cap-matrix-opt to main May 7, 2024 18:31
@sebastiangrimberg sebastiangrimberg force-pushed the sjg/error-estimator-dev branch from c4a2a64 to dc0eb1b Compare May 7, 2024 18:35
@sebastiangrimberg sebastiangrimberg force-pushed the sjg/error-estimator-dev branch from dc0eb1b to 9f76946 Compare May 9, 2024 16:07
@sebastiangrimberg sebastiangrimberg merged commit 28401e1 into main May 9, 2024
17 checks passed
@sebastiangrimberg sebastiangrimberg deleted the sjg/error-estimator-dev branch May 9, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amr Related to adaptive mesh refinement (AMR) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants