-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build macOS wheels and integration tests #197
Conversation
with: | ||
toolchain: stable | ||
override: true | ||
uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have we changed this?
Should we update the other workflows too: https://github.com/search?q=repo%3Aawslabs%2Fs3-connector-for-pytorch%20actions-rs%2Ftoolchain%40v1&type=code?
14b401a
to
e53adc1
Compare
This is pretty simple, mostly just adding macos-13 (x86) and macos-14 (arm64) runners to the matrix. We also need to explicitly disable MPS for PyTorch to run correctly on the memory-limited GHA runners. Signed-off-by: James Bornholt <bornholt@amazon.com>
ea0fc42
to
21804c8
Compare
|
||
- name: Install pipx | ||
run: | | ||
python -m pip install --upgrade pipx | ||
which python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these which
lines still wanted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used them for debugging, but left them on purpose, as they helped to understand the problem, and I am expecting changes for pip setup in the upcoming runner updates.
This is pretty simple, mostly just adding macos-13 (x86) and macos-14 (arm64) runners to the matrix. We also need to explicitly disable MPS for PyTorch to run correctly on the GHA runners which don't have access to that hardware.
dnanuti@: Build on macos runners had occasionally a flaky behaviour, as
actions/setup-python
requires/Users/runner/hostedtoolcache
to exist to work properly with macosx due to fixed shared library path.Additionally,
pipx
was not always properly configured, depending on the runner image, encountered this on macos-14 arm64 runners too (example run).Also worth mentioning:
This applies just for the build for 3.8 macosx arm64 and had the same behaviour with the initial changes.
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.