Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build macOS wheels and integration tests #197

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

jamesbornholt
Copy link
Member

@jamesbornholt jamesbornholt commented Apr 2, 2024

This is pretty simple, mostly just adding macos-13 (x86) and macos-14 (arm64) runners to the matrix. We also need to explicitly disable MPS for PyTorch to run correctly on the GHA runners which don't have access to that hardware.


dnanuti@: Build on macos runners had occasionally a flaky behaviour, as actions/setup-python requires /Users/runner/hostedtoolcache to exist to work properly with macosx due to fixed shared library path.
Additionally, pipx was not always properly configured, depending on the runner image, encountered this on macos-14 arm64 runners too (example run).

Also worth mentioning:

Warning: While cibuildwheel can build CPython 3.8 universal2/arm64 wheels, we cannot test the arm64 part of them, even when running on an Apple Silicon machine. This is because we use the x86_64 installer of CPython 3.8. See the discussion in pypa/cibuildwheel#1169 for the details. To silence this warning, set CIBW_TEST_SKIP: "cp38-macosx_*:arm64".

This applies just for the build for 3.8 macosx arm64 and had the same behaviour with the initial changes.


By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.

with:
toolchain: stable
override: true
uses: dtolnay/rust-toolchain@stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:02 — with GitHub Actions Failure
@dnanuti dnanuti force-pushed the workflow/macos-wheels branch from 14b401a to e53adc1 Compare April 5, 2024 13:27
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:27 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:27 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:27 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:27 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:27 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:27 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:27 — with GitHub Actions Failure
@dnanuti dnanuti had a problem deploying to integration-tests April 5, 2024 13:27 — with GitHub Actions Failure
jamesbornholt and others added 3 commits April 10, 2024 09:57
This is pretty simple, mostly just adding macos-13 (x86) and macos-14
(arm64) runners to the matrix. We also need to explicitly disable MPS
for PyTorch to run correctly on the memory-limited GHA runners.

Signed-off-by: James Bornholt <bornholt@amazon.com>
@dnanuti dnanuti force-pushed the workflow/macos-wheels branch from ea0fc42 to 21804c8 Compare April 10, 2024 08:57
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:57 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:57 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:57 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:57 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:58 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:58 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:58 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:58 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:58 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 08:58 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:06 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:06 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:07 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:07 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:07 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:07 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:07 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:07 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:07 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests April 10, 2024 16:07 — with GitHub Actions Inactive

- name: Install pipx
run: |
python -m pip install --upgrade pipx
which python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these which lines still wanted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used them for debugging, but left them on purpose, as they helped to understand the problem, and I am expecting changes for pip setup in the upcoming runner updates.

@dnanuti dnanuti merged commit 23806df into main Apr 11, 2024
68 checks passed
@dnanuti dnanuti deleted the workflow/macos-wheels branch April 11, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants