Make required context parameters required #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
required-context-params
branch
from
5d76520 to
38c137b
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
required-context-params
branch
from
64840e7 to
b403adf
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Aug 31, 2023
Comment on lines
118
to
123
| if let Some(field) = field { | ||
| if field.as_ref() != "" { | ||
| return Some(field) | ||
| } | ||
| } | ||
| None |
There was a problem hiding this comment.
I think this can be one line:
Suggested change
| if let Some(field) = field { | |
| if field.as_ref() != "" { | |
| return Some(field) | |
| } | |
| } | |
| None | |
| field.map(AsRef::as_ref).filter(|s| s != "") |
rcoh
force-pushed
the
required-context-params
branch
from
e473125 to
de61ad7
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When a
@contextParamis marked as required, we will enforce it on inputs. Since these fields may influence endpoint, omitting them can result in a different target being hit.Description
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.