chore: upgrade aws-config for aarch64-pc-windows support #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
NickDarvey
changed the title
|
Fixed in 958a664 |
|
Looks like some tests are still failing. Can you try building with the |
Yeah, that revealed dynamodb needed a bump too |
|
Alright, some breaking changes to types. This needs some more work |
|
I didn't scroll far enough down to find the breaking changes. Allllllllllllllll the changesNovember 14th, 2023Service Features:
Service Documentation:
Crate Versions Click to expand to view crate versions...
November 2nd, 2023Breaking Changes:
New this release:
Crate Versions Click to expand to view crate versions...
|
|
Okay, I think we're good now. One test failed locally for me, but I think it's unrelated to this change. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
- Coverage 79.83% 79.82% -0.01%
==========================================
Files 207 207
Lines 58806 58798 -8
Branches 58806 58798 -8
==========================================
- Hits 46950 46938 -12
Misses 9120 9120
- Partials 2736 2740 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
aws-configbecauseaws-config@0.56has a dependency onring@0.161 which does not supportaarch64-pc-windows2.Support for
aarch64-pc-windowswas added inring@0.173 whichaws-config@0.57uses 4.Unfortunately, there's a hideous amount of changes between these two version, although no breaking changes are mentioned in the changelog 5. Does a maintainer here have a suggestion of what kind of testing we might need to do?
Footnotes
https://github.com/awslabs/aws-sdk-rust/blob/d212f8dd428e140b8ff414261f6921b2901a7dbc/sdk/aws-config/Cargo.toml#L98-L100 ↩
https://github.com/briansmith/ring/issues/1514 ↩
https://github.com/briansmith/ring/issues/1167#issuecomment-1745560468 ↩
https://github.com/awslabs/aws-sdk-rust/blob/511abe92a476c27d1e49758fe54eac0886ecf731/sdk/aws-config/Cargo.toml#L98-L100 ↩
https://github.com/awslabs/aws-sdk-rust/compare/d212f8d..511abe9 ↩