Fix codegen for unions with the @httpPayload trait
#2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
force-pushed
the
jdisanti-fix-medicalimaging
branch
from
284b127
to
8f927c9
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Aug 31, 2023
ysaito1001
pushed a commit
that referenced
this pull request
Sep 15, 2023
This PR incorporates the new test cases in Smithy from smithy-lang/smithy#1908, and adds support to `@restXml` and `@restJson1` for unions with the `@httpPayload` trait. This resolves #1896. This also fixes code generation for the latest `medicalimaging` SDK model. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
ysaito1001
added a commit
that referenced
this pull request
Sep 15, 2023
## Motivation and Context Cherry-picks #2969, since our internal build based on the `smithy-rs-release-0.56.x` branch failed to code gen for the latest `medicalimaging` SDK model. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Co-authored-by: John DiSanti <jdisanti@amazon.com>
aws-sdk-rust-ci
pushed a commit
to awslabs/aws-sdk-rust
that referenced
this pull request
Sep 19, 2023
…` trait (#2987) ## Motivation and Context Cherry-picks smithy-lang/smithy-rs#2969, since our internal build based on the `smithy-rs-release-0.56.x` branch failed to code gen for the latest `medicalimaging` SDK model. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Co-authored-by: John DiSanti <jdisanti@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the new test cases in Smithy from smithy-lang/smithy#1908, and adds support to
@restXmland@restJson1for unions with the@httpPayloadtrait. This resolves #1896.This also fixes code generation for the latest
medicalimagingSDK model.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.