Add tests for unions as httpPayloads #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Aug 8, 2023
kstich
force-pushed
the
unionPayload_tests
branch
2 times, most recently
from
6404325
to
9a0d0a3
Compare
github-merge-queue bot
pushed a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Aug 31, 2023
This PR incorporates the new test cases in Smithy from smithy-lang/smithy#1908, and adds support to `@restXml` and `@restJson1` for unions with the `@httpPayload` trait. This resolves #1896. This also fixes code generation for the latest `medicalimaging` SDK model. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
kstich
force-pushed
the
unionPayload_tests
branch
from
9a0d0a3
to
f08e0aa
Compare
kstich
force-pushed
the
unionPayload_tests
branch
from
f08e0aa
to
ae8408f
Compare
mtdowling
approved these changes
Aug 31, 2023
ysaito1001
pushed a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Sep 15, 2023
This PR incorporates the new test cases in Smithy from smithy-lang/smithy#1908, and adds support to `@restXml` and `@restJson1` for unions with the `@httpPayload` trait. This resolves #1896. This also fixes code generation for the latest `medicalimaging` SDK model. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1462
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.