Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aws_smithy_http::result into aws-smithy-types #3092

Closed
Tracked by #3019
rcoh opened this issue Oct 24, 2023 · 0 comments
Closed
Tracked by #3019

Move aws_smithy_http::result into aws-smithy-types #3092

rcoh opened this issue Oct 24, 2023 · 0 comments
Assignees

Comments

@rcoh
Copy link
Collaborator

rcoh commented Oct 24, 2023

No description provided.

@ysaito1001 ysaito1001 changed the title Move ConnectorError into a future-stable crate Move aws_smithy_http::result into aws-smithy-types Oct 24, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 27, 2023
…runtime-api` (#3103)

## Motivation and Context
Implements #3092 

## Description
This PR moves the `connection` and `result` modules from
`aws-smithy-http` to `aws_smithy_runtime_api`. `SdkError` is primarily
used within the context of the orchestrator, hence
`aws_smithy_runtime_api` instead of `aws-smithy-types`.

Like the previous sibling PRs, type aliases for affected pub items are
left in `aws_smithy_http` for backwards compatibility. However, due to
lack of trait aliases, a trait `CreateUnhandledError` needs to be
consumed from `aws_smithy_runtime_api`.

This PR also updates existing places that consumed those moved types so
they now depend on `aws-smithy-runtime-api` to do so.

## Testing
Relied on the existing tests, which ensured no deprecated warnings of
using moved types from the old place were issued.

## Checklist
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@rcoh rcoh closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants