Move result and connection from aws-smithy-http to aws-smithy-runtime-api
#3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysaito1001
added
breaking-change
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Oct 27, 2023
Velfi
approved these changes
Oct 27, 2023
This commit addresses #3103 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
deleted the
ysaito/move-result-module-from-smithy-http-to-smithy-runtime-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Implements #3092
Description
This PR moves the
connectionandresultmodules fromaws-smithy-httptoaws_smithy_runtime_api.SdkErroris primarily used within the context of the orchestrator, henceaws_smithy_runtime_apiinstead ofaws-smithy-types.Like the previous sibling PRs, type aliases for affected pub items are left in
aws_smithy_httpfor backwards compatibility. However, due to lack of trait aliases, a traitCreateUnhandledErrorneeds to be consumed fromaws_smithy_runtime_api.This PR also updates existing places that consumed those moved types so they now depend on
aws-smithy-runtime-apito do so.Testing
Relied on the existing tests, which ensured no deprecated warnings of using moved types from the old place were issued.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.