Fix broken reference to fail()
after jest-upgrade
#645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Jest versions >= 27 replace jest-jasmine2 with jest-circus, which does not have an implementation for the
fail()
method, but still has the method stub defined in the Jest type-defs. This change implements thefail()
method in protocol test suites, and adjusts the thrown message to actually state the error, instead of justerr
.For more information, see DefinitelyTyped maintainer discussion
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.
Testing
Run the protocol test suite after making changes and running the codegen
Before changes:
After changes: