Fix Error printout for protocol-response tests #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest versions >= 27 replace jest-jasmine2 with jest-circus, which does not have an implementation for the `fail()` method, but still has the method stub defined in the Jest type-defs. This change implements the `fail()` method in protocol test suites, and adjusts the thrown message to actually state the error, instead of just `err`.
When writing strings with newlines and interpolation, code can get mangled and won't compile. This change makes the error printout a single-line and not interpolated.
haydenbaker
changed the title
srchase
approved these changes
Dec 13, 2022
milesziemer
pushed a commit
to milesziemer/smithy-typescript
that referenced
this pull request
Dec 14, 2022
* Fix broken reference to `fail()` after jest-upgrade Jest versions >= 27 replace jest-jasmine2 with jest-circus, which does not have an implementation for the `fail()` method, but still has the method stub defined in the Jest type-defs. This change implements the `fail()` method in protocol test suites, and adjusts the thrown message to actually state the error, instead of just `err`. * Remove interpolation of error in response tests When writing strings with newlines and interpolation, code can get mangled and won't compile. This change makes the error printout a single-line and not interpolated.
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* Fix broken reference to `fail()` after jest-upgrade Jest versions >= 27 replace jest-jasmine2 with jest-circus, which does not have an implementation for the `fail()` method, but still has the method stub defined in the Jest type-defs. This change implements the `fail()` method in protocol test suites, and adjusts the thrown message to actually state the error, instead of just `err`. * Remove interpolation of error in response tests When writing strings with newlines and interpolation, code can get mangled and won't compile. This change makes the error printout a single-line and not interpolated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixes an issue brought in through #645
Testing
(NOTE: I intentionally made this test fail)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.