Fix MapMembers grammar and update test #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IDL 2, map members can be mixed in, so Smithy grammar should reflect their optionality. smithy-lang#1533 incorrectly changed MapMembers grammar to make both MapKey and MapValue optional together, when they are optional separately. This PR fixes the MapMembers grammar to allow MapKey and MapValue to be optional separately, and updates a test case to reflect that.
mtdowling
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IDL 2, map members can be mixed in, so Smithy grammar should reflect their optionality. #1533 incorrectly changed MapMembers grammar to make both MapKey and MapValue optional together, when they are optional separately. This PR fixes the MapMembers grammar to allow MapKey and MapValue to be optional separately, and updates a test case to reflect that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.