Update trailing line break, list member grammar #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesziemer
force-pushed
the
line-break-and-list-member-grammar
branch
2 times, most recently
from
01595bb to
b7d3357
Compare
srchase
approved these changes
Dec 12, 2022
Grammar no longer requires a trailing line break after shape bodies, only between shapes. Also, list and map members are now optional because in IDL 2 they can be mixed in.
milesziemer
force-pushed
the
line-break-and-list-member-grammar
branch
from
b7d3357 to
edc9505
Compare
milesziemer
added a commit
to milesziemer/smithy
that referenced
this pull request
Dec 13, 2022
smithy-lang#1533 incorrectly changed MapMembers grammar to make both MapKey and MapValue optional together, when they are optional separately. This PR fixes the MapMembers grammar to allow MapKey and MapValue to be optional separately, and updates a test case to reflect that.
milesziemer
added a commit
to milesziemer/smithy
that referenced
this pull request
Dec 13, 2022
smithy-lang#1533 incorrectly changed MapMembers grammar to make both MapKey and MapValue optional together, when they are optional separately. This PR fixes the MapMembers grammar to allow MapKey and MapValue to be optional separately, and updates a test case to reflect that.
milesziemer
added a commit
to milesziemer/smithy
that referenced
this pull request
Dec 13, 2022
In IDL 2, map members can be mixed in, so Smithy grammar should reflect their optionality. smithy-lang#1533 incorrectly changed MapMembers grammar to make both MapKey and MapValue optional together, when they are optional separately. This PR fixes the MapMembers grammar to allow MapKey and MapValue to be optional separately, and updates a test case to reflect that.
milesziemer
added a commit
that referenced
this pull request
Dec 13, 2022
In IDL 2, map members can be mixed in, so Smithy grammar should reflect their optionality. #1533 incorrectly changed MapMembers grammar to make both MapKey and MapValue optional together, when they are optional separately. This PR fixes the MapMembers grammar to allow MapKey and MapValue to be optional separately, and updates a test case to reflect that.
daddykotex
added a commit
to disneystreaming/smithy-translate
that referenced
this pull request
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammar no longer requires a trailing line break after shape bodies, only between shapes,
and list members are now optional, because they can be mixed in.
Issue #, if available:
#1522
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.