Add test coverage #1366
Merged
Add test coverage #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
sondavidb
force-pushed
the
add-test-cov-v2
branch
3 times, most recently
from
00d36c8
to
7c0d476
Compare
sondavidb
force-pushed
the
add-test-cov-v2
branch
from
7c0d476
to
ea61133
Compare
sondavidb
commented
Sep 5, 2024
sondavidb
force-pushed
the
add-test-cov-v2
branch
from
ea61133
to
91f2818
Compare
sondavidb
force-pushed
the
add-test-cov-v2
branch
from
91f2818
to
d473bcc
Compare
austinvazquez
previously approved these changes
Sep 6, 2024
Kern--
reviewed
Sep 6, 2024
sondavidb
force-pushed
the
add-test-cov-v2
branch
from
d473bcc
to
685c2ff
Compare
This change adds code coverage to our workflows and the necessary Makefile targets to support this. Signed-off-by: David Son <davbson@amazon.com>
sondavidb
force-pushed
the
add-test-cov-v2
branch
from
685c2ff
to
f8ecda5
Compare
|
Discussed offline, new changes do the following
|
austinvazquez
approved these changes
Sep 11, 2024
Kern--
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1081
Description of changes:
Added necessary code to add code coverage for our tests. This should help us to get a better idea of where our test suite stands as a whole.
This is really only a preliminary step, the next step would probably be finding a way to combine these metrics, but for now this should help us ensure we're on the right path.
Testing performed:
make test-with-coverageandmake integration-with-coverageBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.