allow setting version and revision #1368
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Allows setting the VERSION and REVISION variables for use in the Makefile, instead of always inferring them from the git repository. This is useful when building from the source tarball instead of a Git repository.
Testing performed:
Built a binary using
VERSION=myversion REVISION=1234567 make soci soci-snapshotter-grpc
and checked the output of--version
commands:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.