Add regression check automation #769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure is because there is no prior benchmark to download. How will that cycle be started? |
We should merge #770 before this PR, It should be able to fetch the required files from the uploaded artifacts |
coderbirju
force-pushed
the
add_regression_check_automation
branch
from
25747ae
to
61c5d20
Compare
coderbirju
force-pushed
the
add_regression_check_automation
branch
3 times, most recently
from
61c409b
to
7685dfc
Compare
This commit adds benchmark_regression_test.yml workflow that runs a regression test by comparing the benchmark results of the current branch with the previous benchmark results of the code in main branch. Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
coderbirju
force-pushed
the
add_regression_check_automation
branch
from
7685dfc
to
64fca1a
Compare
This commit is a test to check if running both the benchmarks in the same workflow would make any difference to the results Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
coderbirju
force-pushed
the
add_regression_check_automation
branch
from
f642744
to
4ecf750
Compare
This commit changes the regression test logic to run benchmarks on main brnach by checking out in the workflow itself instead of a previously uploaded artifact Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
This commit adds changes to the check_regression.sh script to skip the first benchmark times in both the old and new benchmark results and check for regression in the newly calculated p90, this is to combat the skewed reults in the benchmark results due to the variability in github runners. It also moves the threshold limit to 150% Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
coderbirju
force-pushed
the
add_regression_check_automation
branch
from
e3c9110
to
aacef39
Compare
Added print statements to test the benchmark results Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
Commit test 4 Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
This commit adds benchmark_regression_test.yml workflow that runs a regression test by comparing the benchmark results of the current branch with the previous benchmark results of the code in main branch. Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
This commit is a test to check if running both the benchmarks in the same workflow would make any difference to the results Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
This commit adds 10 secs to the RunContainerTaskForReadyLine function Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #770 #785
This commit adds benchmark_regression_test.yml workflow that runs a regression test by comparing the benchmark results of the current branch with the previous benchmark results of the code in main branch.
Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.