-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#88: add delete protections #105
Conversation
Hey @reece - I was not aware of this and accidentally ended up deleting all my control tower groups - is there any way to recover them? |
I was able to recreate the control tower groups by renrolling each account. Good luck. My heart dropped when I discovered that the control tower groups had been deleted, but it all worked out okay in the end. |
// In mid-2022, AWS started using the prefix "AWS" for administrative | ||
// purposes. Without this, ssosync deletes these administrative groups. | ||
if awsGroup.DisplayName[:3] == "AWS" { | ||
log.Warn("Refusing to delete") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.Warn("Refusing to delete") | |
log.Warn("Refusing to delete group with the prefix 'AWS'") |
even if those are delete, why would one need sso for control tower ? |
To use Google as the identity provider for all AWS access. |
Closing due to lack of response from code maintainers. |
Issue #88
Description of changes:
This PR provides two protections against inadvertent deletions:
--delete
is now required to delete users and groups. (A single flag controls both behaviors.)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.