Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multi-stage build Dockerfile for building and serving threat composer. Close #97 #128

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

UrfTheManatee
Copy link
Collaborator

@UrfTheManatee UrfTheManatee commented Aug 6, 2024

…ode from checkout and subsequently copies the website folder into a second stage image that runs the website via nginx

Issue #97 :

Description of changes:
Adds a two-stage docker container that builds a container to build the code and run the application containerized. The container uses the aws-pdk container image to build the first stage and the alpine-nginx to serve the application.

Note that serving happens by default on 80. We assume that the image is run locally over a laptop. If additional SSL/TLS implementation is required it must be done by the user at the loadbalancer level.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ode from checkout and subsequently copies the website folder into a second stage image that runs the website via nginx
@jessieweiyi jessieweiyi changed the title Feat dockerimg feat: Multi-stage build Dockerfile for building and serving threat composer. Close #97 Aug 8, 2024
Copy link
Contributor

@jessieweiyi jessieweiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Awesome work.

@jessieweiyi
Copy link
Contributor

jessieweiyi commented Aug 8, 2024

Next step will be:

  • Update the README file
  • Add a Github step in build.yml to integration test the docker build.

@jessieweiyi jessieweiyi merged commit ebd037b into main Aug 8, 2024
2 checks passed
@jessieweiyi jessieweiyi deleted the feat-dockerimg branch August 8, 2024 04:36
Copy link

github-actions bot commented Aug 8, 2024

🎉 This PR is included in version 1.0.55 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants