Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start trying enabling windooof #504

Closed
wants to merge 10 commits into from
Closed

Conversation

AndyOGo
Copy link

@AndyOGo AndyOGo commented Jun 26, 2018

improves #503

Changes proposed in this pull request:

  • try to make windows work

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AndyOGo AndyOGo added this to the Build milestone Jun 26, 2018
@AndyOGo AndyOGo self-assigned this Jun 26, 2018
@AndyOGo AndyOGo requested review from LucaMele and storm1ng June 26, 2018 11:09
@AndyOGo
Copy link
Author

AndyOGo commented Jun 26, 2018

@LucaMele
@mjenny
So we get logging output now and the created child-process seem to exit.
But Windows shows many more open processes for npm/node scripts. And this happens also for npm install 🤔

I created a ticket for it:
npm/npm#21071

@AndyOGo
Copy link
Author

AndyOGo commented Jul 3, 2018

Wauu at windows all stdout is null 😱

@AndyOGo
Copy link
Author

AndyOGo commented Jul 3, 2018

Windows is super slow...
sindresorhus/execa#142

nodejs/node#3145

@AndyOGo
Copy link
Author

AndyOGo commented Jul 3, 2018

@LucaMele
Turns out that the release script would actually work, but is super slow on windows (npm command take more than 3 minutes to complete)

nodejs/node#21632

@LucaMele
Copy link
Contributor

LucaMele commented Jul 3, 2018

We should really try to not have to make it compatible for windows and change axa's mind that Frontend Developers should become a MAX or an UBUNTU.. this windoof is wasted time IMHO. But i guess is necessary till this mindset is spread...

@storm1ng storm1ng force-pushed the bugfix/windows-spawn-hangs branch from b3268ed to b2bd259 Compare July 3, 2018 13:21
@AndyOGo
Copy link
Author

AndyOGo commented Aug 27, 2018

@LucaMele
Indeed, I agree Windows is silly madness 🤕
But check this PR #553
I finally found the culprit being npm's usage of update-notifier, which lacks support of proxies...

@AndyOGo
Copy link
Author

AndyOGo commented Aug 27, 2018

Therefore this PR can be closed, if haven't any work we want to keep

@LucaMele
Copy link
Contributor

@AndyOGo Please fix travis

Copy link
Contributor

@LucaMele LucaMele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix 54:5 error getter functions should be placed after componentWillUnmount react/sort-comp

@AndyOGo
Copy link
Author

AndyOGo commented Aug 28, 2018

@mele, I would rather delete this PR, cause I created a new one, with a working workaround, what do you think?

@LucaMele
Copy link
Contributor

@AndyOGo , your PR, your desicion :)

@AndyOGo
Copy link
Author

AndyOGo commented Aug 28, 2018

@LucaMele
Alright. So we face primarily two issues on Windows:

  1. Slow scripted npm command caused by update-notifier not supporting proxies and thus awaiting a timeout of 3 minutes
  2. Several node processes start but don't exit at windows - again update-notifier spawns new child process to make their stuff

All of this should be fixed by disabling update-notifier in #553

If all is working as expected now, forcefully killing hanging node processes should not be needed anymore... so I would just close this PR

@AndyOGo AndyOGo closed this Aug 28, 2018
@jackblackCH jackblackCH deleted the bugfix/windows-spawn-hangs branch May 13, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants