test: ensure to check write(2) return value

Signed-off-by: Jens Axboe <axboe@kernel.dk>
axboe · Dec 8, 2023 · f94a237 · f94a237
1 parent 8abbdc5
commit f94a237
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 5 deletions.
diff --git a/test/buf-ring-nommap.c b/test/buf-ring-nommap.c
@@ -85,7 +85,14 @@ int main(int argc, char *argv[])
 
 	io_uring_submit(&ring);
 
-	write(fds[1], "Hello", 5);
+	ret = write(fds[1], "Hello", 5);
+	if (ret < 0) {
+		perror("write");
+		return T_EXIT_FAIL;
+	} else if (ret != 5) {
+		fprintf(stderr, "short write %d\n", ret);
+		return T_EXIT_FAIL;
+	}
 
 	ret = io_uring_wait_cqe(&ring, &cqe);
 	if (ret) {

diff --git a/test/fd-install.c b/test/fd-install.c
@@ -183,7 +183,14 @@ static int test_working(struct io_uring *ring)
 	io_uring_submit(ring);
 
 	/* put some data in the pipe */
-	write(fds[1], "Hello", 5);
+	ret = write(fds[1], "Hello", 5);
+	if (ret < 0) {
+		perror("write");
+		return T_EXIT_FAIL;
+	} else if (ret != 5) {
+		fprintf(stderr, "short write %d\n", ret);
+		return T_EXIT_FAIL;
+	}
 
 	ret = io_uring_wait_cqe(ring, &cqe);
 	if (ret) {
@@ -218,7 +225,14 @@ static int test_working(struct io_uring *ring)
 	fds[0] = cqe->res;
 	io_uring_cqe_seen(ring, cqe);
 
-	write(fds[1], "Hello", 5);
+	ret = write(fds[1], "Hello", 5);
+	if (ret < 0) {
+		perror("write");
+		return T_EXIT_FAIL;
+	} else if (ret != 5) {
+		fprintf(stderr, "short write %d\n", ret);
+		return T_EXIT_FAIL;
+	}
 
 	/* normal pipe read should now work with new fd */
 	ret = read(fds[0], buf, sizeof(buf));
@@ -243,7 +257,14 @@ static int test_working(struct io_uring *ring)
 	}
 	io_uring_cqe_seen(ring, cqe);
 
-	write(fds[1], "Hello", 5);
+	ret = write(fds[1], "Hello", 5);
+	if (ret < 0) {
+		perror("write");
+		return T_EXIT_FAIL;
+	} else if (ret != 5) {
+		fprintf(stderr, "short write %d\n", ret);
+		return T_EXIT_FAIL;
+	}
 
 	/* normal pipe read should still work with new fd */
 	ret = read(fds[0], buf, sizeof(buf));
@@ -259,7 +280,14 @@ static int test_working(struct io_uring *ring)
 	io_uring_submit(ring);
 
 	/* put some data in the pipe */
-	write(fds[1], "Hello", 5);
+	ret = write(fds[1], "Hello", 5);
+	if (ret < 0) {
+		perror("write");
+		return T_EXIT_FAIL;
+	} else if (ret != 5) {
+		fprintf(stderr, "short write %d\n", ret);
+		return T_EXIT_FAIL;
+	}
 
 	ret = io_uring_wait_cqe(ring, &cqe);
 	if (ret) {