feat(minor-router): check duplicate chain name when register chain #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiyizxx
force-pushed
the
AXE-5193-service-registry-check-core-duplicate-chain-name-when-register-
branch
from
86f39ea
to
fa02e12
Compare
Co-authored-by: Haiyi Zhong <haiyizxx@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
- Coverage 93.55% 93.47% -0.09%
==========================================
Files 242 243 +1
Lines 34080 34228 +148
==========================================
+ Hits 31884 31995 +111
- Misses 2196 2233 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
haiyizxx
force-pushed
the
AXE-5193-service-registry-check-core-duplicate-chain-name-when-register-
branch
from
41d2dbe
to
d7595ce
Compare
cjcobb23
reviewed
Oct 1, 2024
cjcobb23
approved these changes
Oct 2, 2024
haiyizxx
deleted the
AXE-5193-service-registry-check-core-duplicate-chain-name-when-register-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes