Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ampd): stellar tx id format #648

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(ampd): stellar tx id format #648

wants to merge 4 commits into from

Conversation

milapsheth
Copy link
Member

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Steps to Test

Expected Behaviour

Other Notes

@milapsheth milapsheth requested a review from a team as a code owner October 4, 2024 10:51
cjcobb23
cjcobb23 requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you summarize what this PR is about?

ampd/src/stellar/http_client.rs Show resolved Hide resolved
ampd/src/stellar/http_client.rs Show resolved Hide resolved
ampd/src/stellar/http_client.rs Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.69%. Comparing base (81b6061) to head (35df2a9).

Files with missing lines Patch % Lines
ampd/src/stellar/http_client.rs 90.90% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files         243      243           
  Lines       35678    35688   +10     
=======================================
+ Hits        33427    33437   +10     
  Misses       2251     2251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcobb23 cjcobb23 cjcobb23 requested changes

@haiyizxx haiyizxx haiyizxx approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milapsheth @haiyizxx @cjcobb23