Use the correct name of the binary encoding selector #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library currently calls
hash.digest('bin')
which crashesbrowserify-sha3
.hash
is either the C implementation which comes fromsha3
package (when available) or the JS one frombrowserify-sha3
otherwise. The latter clearly expects the value to be'binary'
, not'bin'
. Same forsha3
but it's more lax and just assumes'binary'
when the encoding is not recognized.I'm not sure how to write a test for this but I checked it manually and
'binary'
works with both.Error output
I got this in ethereum/solc-bin#40. Apparently
sha3
must have failed to build in Travis and it fell back tobrowserify-sha3
: https://travis-ci.org/github/ethereum/solc-bin/builds/744413140