cmd, core, eth, trie: track deleted nodes #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francesco4203
force-pushed
the
track-deleted-nodes
branch
2 times, most recently
from
ea7255b
to
31945a9
Compare
Francesco4203
commented
Sep 17, 2024
| // node's original value. The rlp-encoded blob is preferred to be loaded from | ||
| // database because it's easy to decode node while complex to encode node to blob. | ||
| func (t *Trie) resolveAndTrack(n hashNode, prefix []byte) (node, error) { | ||
| blob, err := t.reader.nodeBlob(prefix, common.BytesToHash(n)) |
There was a problem hiding this comment.
We need to track the encoded node here, so get the blob first for tracer and then return the decoded one.
| // getPrev returns the cached original value of the specified node. | ||
| func (t *tracer) getPrev(key []byte) []byte { | ||
| func (t *tracer) getPrev(path []byte) []byte { | ||
| // Don't panic on uninitialized tracer, it's possible in testing. |
There was a problem hiding this comment.
// Tracer isn't used right now, remove this check later. -> Update it for correcting the status.
Francesco4203
force-pushed
the
track-deleted-nodes
branch
from
31945a9
to
4fbda95
Compare
| case opHash: | ||
| tr.Hash() | ||
| case opCommit: | ||
| hash, nodes, err := tr.Commit(false) | ||
| root, nodes, err := tr.Commit(true) |
There was a problem hiding this comment.
Not sure why they change to collect Dirty Leaf here too 🤔
There was a problem hiding this comment.
I think since they've just enabled the tracer here, so they just try to commit everything for full coverage.
Francesco4203
force-pushed
the
track-deleted-nodes
branch
2 times, most recently
from
89eb9bb
to
a40e2d1
Compare
Francesco4203
force-pushed
the
track-deleted-nodes
branch
from
a40e2d1
to
dfc5035
Compare
huyngopt1994
merged commit f61a05d
into
axieinfinity:path-base-implementing
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: ethereum/go-ethereum#25757
Important changes:
A storage trie is now identified by StateRoot (root of state/account trie), Owner, Root. The state/account trie is identified with StateRoot = Root. Those params are now needed for init a trie.
Separate list of dirty nodes to updated nodes and deleted node. Also separate the updating/deleting operations.
Track previous value of each node (before committing).
Apply delete tracking logics to committer.
Add
trie_reader.go, interface for reaching database layer(s) from trie. Support backward compatibility: can usehash_readerfor old hash based scheme, and can usediffLayerfor path based scheme in the future PRs.Add metrics for tracking trie commits.