Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint errors #63

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Fix lint errors #63

merged 1 commit into from
Apr 6, 2024

Conversation

smorimoto
Copy link
Contributor

@smorimoto smorimoto commented Apr 5, 2024 •
edited
Loading

@smorimoto
Fix lint errors
47ea3c8 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
smorimoto
smorimoto commented Apr 6, 2024
View reviewed changes
.golangci.yaml Show resolved Hide resolved
.golangci.yaml Show resolved Hide resolved
.golangci.yaml Show resolved Hide resolved
lukasmalkmus
lukasmalkmus approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@lukasmalkmus lukasmalkmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Really appreciate the detailed comments of yours!!!

@lukasmalkmus lukasmalkmus enabled auto-merge (rebase) April 6, 2024 20:22
@lukasmalkmus lukasmalkmus merged commit 97acfcf into axiomhq:main Apr 6, 2024
3 checks passed
@smorimoto smorimoto deleted the fix-lint-errors branch April 6, 2024 21:51
@smorimoto
Copy link
Contributor Author

My pleasure!

@lukasmalkmus
Copy link
Contributor

@smorimoto Tagged v0.7.1.

@smorimoto
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmalkmus lukasmalkmus lukasmalkmus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smorimoto @lukasmalkmus