Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axios rejects on the successful request (204) in IE9 #201

Closed
savantaparna opened this issue Jan 22, 2016 · 2 comments
Closed

Axios rejects on the successful request (204) in IE9 #201

savantaparna opened this issue Jan 22, 2016 · 2 comments

Comments

@savantaparna
Copy link

Current behavior:

Axios rejects the promise on successful request in IE9 on status code 204.

Expected behavior:

Axios should resolve the promise when it receives status code as 204 in IE9.

I have found the discussion of this same issue -
http://stackoverflow.com/questions/10046972/msie-returns-status-code-of-1223-for-ajax-request

IE coerces 204 to 1223 and this falls out range of success codes (>= 200 && < 300).
savantaparna pushed a commit to savantaparna/axios that referenced this issue Jan 22, 2016
Fixing axios#201 by treating status code 1223 as a success code.
1f2d790
@mzabriskie
Copy link
Member

Wouldn't expect anything less from IE :/

mzabriskie added a commit that referenced this issue Jan 22, 2016
@mzabriskie
Merge pull request #202 from savantaparna/master
c73389e 
Fixing #201 by treating status code 1223 as a success code.
@mzabriskie
Copy link
Member

This fix is available in 0.9.1

@michaeldzjap michaeldzjap mentioned this issue Oct 29, 2017
Closed
@m0n1ter m0n1ter mentioned this issue Nov 17, 2018
Closed
@axios axios locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mzabriskie @savantaparna