Update types check #3342
Merged
Update types check #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update isFormdata,isArrayBuffer and isURLSearchParams, because value and Formdata(ArrayBuffer or URLSearchParams) are not the same Window sometimes.
|
@jasonsaayman hi, when do you plan to release this change? I have a problem with this change. |
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
update isFormdata,isArrayBuffer and isURLSearchParams, because value and Formdata(ArrayBuffer or URLSearchParams) are not the same Window sometimes. Co-authored-by: Jay <jasonsaayman@gmail.com>
mlazari
reviewed
Jan 30, 2022
| @@ -54,7 +54,7 @@ function isArrayBuffer(val) { | |||
| * @returns {boolean} True if value is an FormData, otherwise false | |||
| */ | |||
| function isFormData(val) { | |||
| return (typeof FormData !== 'undefined') && (val instanceof FormData); | |||
| return toString.call(val) === '[object FormData]'; | |||
There was a problem hiding this comment.
The result of toString.call(val) in my React Native project returns [object Object] rather than [object FormData] which makes file upload fail with this change. See #4412
There was a problem hiding this comment.
This issue seems related too: form-data/form-data#396
There was a problem hiding this comment.
Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/toString#using_tostring_to_detect_object_class using this way to detect object class is unreliable, so maybe it shouldn't be used?
This was referenced Feb 22, 2022
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update isFormdata,isArrayBuffer and isURLSearchParams, because value and Formdata(ArrayBuffer or URLSearchParams) are not in the same Window sometimes, such as iframe.