Ensure valid whitespace is not trimmed when html parsing mode is used #1689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Consider the following input:
or
The correct output should be:
This is a sentence with a link Click me and some more text.
What is actually being produced is the following:
This is a sentence with a linkClick meand some more text.
This is only an issue now that the leading and trailing whitespace trimming is enabled, but only affects HTML style parsing, since HTML has
 
and
, which both insert spaces into the text. Those spaces end up being trimmed, when they should not be.The fix in this PR will only disable trailing whitespace trimming if and only if html mode is enabled, so it will not have any affect in any other scenario. This fixes the issue with
 
and
, ensuring the spaces generated by them are part of the output.Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR