Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve project templates #1713

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Improve project templates #1713

merged 5 commits into from
Feb 21, 2024

Conversation

halx99
Copy link
Collaborator

@halx99 halx99 commented Feb 21, 2024 •
edited
Loading

Describe your changes

  • Since the template for LUA/CPP is near the same, keep a single template for both CPP and LUA, and when copy to target folder add/remove files by it type.
  • Remove targets HelloLua, HelloCpp from engine CMakeLists.txt

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 added this to the 2.1.2 milestone Feb 21, 2024
@halx99 halx99 added the enhancement New feature or request label Feb 21, 2024
@halx99 halx99 linked an issue Feb 21, 2024 that may be closed by this pull request
Can't start lua project on ios #1712
Closed
@halx99 halx99 mentioned this pull request Feb 21, 2024
Closed
@halx99 halx99 merged commit c222d2e into dev Feb 21, 2024
1 check failed
@halx99 halx99 deleted the improve-project-templates branch February 21, 2024 16:41
@bintester
Copy link
Contributor

@halx99 @rh101
now , it can run , think you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

Can't start lua project on ios
2 participants
@halx99 @bintester