Fix texture recreation when GL context is lost #1763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR contains 3 changes:
When GL context is lost on Android all textures in the context are destroyed implicitly. But
TextureInfoGL::onRendererRecreated()
callsglDeleteTextures()
on old texture IDs and if other new textures have already allocated these IDs, then it ends up deleting those new textures corrupting their state. and the OpenGLState was reset before eventEVENT_RENDERER_RECREATED
fired incore/platform/android/javaactivity-android.cpp
TextureCubeGL
seems to listen toEVENT_COME_TO_FOREGROUND
when it should listen toEVENT_RENDERER_RECREATED
, so fixed that.Did some renaming to reflect that things are being used for renderer recreated event.
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR