[Spine] Fix two color tint data not being copied across to backend buffer on first frame #1875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The two color tint vertex data was being updated after a new render command (
TwoColorTrianglesCommand
) is added, but the issue is that theaddCommand
method would have already updated the back-end buffer with the passed in data. This meant that the vertex data in the back-end buffer did not contain the updated values.It's primarily an issue with
TwoColorTrianglesCommand
, because of how it works. The non-two color tint code usesTrianglesCommand
, and does not seem to copy the data onaddCommand
, but rather hold a reference to the vertex data to be used later in the rendering process (if I understand it correctly). Regardless of that, the section for non-two color tint has also been changed to update the data before theRenderer::addCommand
is called.Issue ticket number and link
#1824
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR