-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
just addressing some compiler warnings on windows #1954
Conversation
@IamSanjid It would be better if you do all the changes, then create the PR, but since you have already created the PR, then do all the changes and then commit in one go. The reason is that now you've created the PR, every commit you make triggers the build system, or stops it and restarts it, and also sends out email notifications for every single commit to anyone who automatically subscribed to changes in this repo. So, at the very least, please change this PR to a draft until it is ready to be reviewed. Please be aware of this for any future changes. It is always best to create the branch on your local PC, make any changes and commit them locally, and when it's complete, then create the pull request against the repository. |
Ow I am sorry I didn't realize that |
This should be it for now except regarding 3rd party, lua_bindings and unitialized member warning |
Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR