Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fatal signal bactrace #350

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented Oct 21, 2024

This adds handlers for SIGSEGV and SIGABRT at least on x86_64/arm based linux systems and then reports a crash report in case these signals are triggered.

@bazsi bazsi force-pushed the add-fatal-signal-bactrace branch from ba332e6 to 5c6381d Compare October 24, 2024 01:35
@alltilla alltilla requested a review from bshifter October 24, 2024 08:55
bshifter
bshifter previously approved these changes Oct 25, 2024
Copy link
Member

@bshifter bshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bazsi bazsi force-pushed the add-fatal-signal-bactrace branch from 5c6381d to a136792 Compare October 27, 2024 11:30
@bazsi bazsi force-pushed the add-fatal-signal-bactrace branch from a136792 to f977609 Compare October 27, 2024 11:37
@bazsi
Copy link
Member Author

bazsi commented Oct 27, 2024

This now only depends on the 4 commits in #357

@bazsi bazsi force-pushed the add-fatal-signal-bactrace branch 3 times, most recently from a4dc3f7 to 6d24179 Compare November 2, 2024 17:59
@bazsi
Copy link
Member Author

bazsi commented Nov 8, 2024

musl lacks backtrace() and backtrace_symbols() functions. There are replacement libraries (libexecinfo and libbacktrace) but libexecinfo was archived and removed from Alpine. Libbacktrace is not even packaged.

With that this branch is now on hold.

@bazsi bazsi force-pushed the add-fatal-signal-bactrace branch from 90aac6c to ed52606 Compare November 8, 2024 07:45
@bazsi bazsi changed the title Add fatal signal bactrace WIP: Add fatal signal bactrace Nov 8, 2024
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
@bazsi bazsi force-pushed the add-fatal-signal-bactrace branch from ed52606 to bc5c4fd Compare December 11, 2024 21:22
@bazsi bazsi changed the title WIP: Add fatal signal bactrace Add fatal signal bactrace Dec 11, 2024
@bazsi
Copy link
Member Author

bazsi commented Dec 11, 2024

There's now a new iteration that should also work on Alpine Linux and uses libunwind to produce the backtrace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants