Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[axolotl-web] Adjust format used for mic-recorder-to-mp3 git npm dependency #874

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

olof-nord
Copy link
Collaborator

Adjust format used for mic-recorder-to-mp3 npm git dependency and update npm lock file.

The format used is based on the minimal-git node flatpak-builder-tools test case

https://github.com/flatpak/flatpak-builder-tools/blob/master/node/tests/data/packages/minimal-git/package.json

This should solve #838

This bug has two related issues in flatpak-builder-tools:

Update npm lock file

The format used is based on the minimal-git node flatpak-builder-tools test case

https://github.com/flatpak/flatpak-builder-tools/blob/master/node/tests/data/packages/minimal-git/package.json

This should solve #838
@olof-nord
Copy link
Collaborator Author

Note that the library stays the same, and the npm build should be the same too: this is effectively just to get the flatpak tooling to pick up the dependency correctly.

@olof-nord olof-nord requested a review from nanu-c August 26, 2022 15:55
@olof-nord
Copy link
Collaborator Author

The PR #855 did unfortunately not address the issue.

@olof-nord olof-nord changed the title [axolotl-web] Adjust format used for mic-recorder-to-mp3 git dependency [axolotl-web] Adjust format used for mic-recorder-to-mp3 git npm dependency Aug 26, 2022
@nanu-c
Copy link
Collaborator

nanu-c commented Aug 26, 2022

Thank you!

@nanu-c nanu-c merged commit bf83276 into main Aug 26, 2022
@olof-nord olof-nord deleted the axolotl-web-mic-recorder-to-mp3-dependency branch August 27, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants