Avoid recursive file load

[ccamel]

Backport of ichiban/prolog#334 fixing ichiban/prolog#329.

[coderabbitai]

Walkthrough

The changes in this pull request primarily modify the ensureLoaded method in the VM struct and the flush method in the text struct within the engine/text.go file. The ensureLoaded method now marks files as loaded immediately upon entry, with adjustments for failure handling. The flush method has been updated to enforce stricter validation on user-defined predicates by checking their discontiguous property. These changes aim to improve file loading accuracy and error handling in the system.

Changes

File	Change Summary
engine/text.go	Modified ensureLoaded method logic for immediate file loading and failure handling. Updated flush method to check for discontiguous property of predicates, returning an error if conditions are not met.

Assessment against linked issues

Objective	Addressed	Explanation
Avoid recursive file load (#334)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          23       23           
  Lines        6581     6582    +1     
=======================================
+ Hits         6469     6470    +1     
  Misses         81       81           
  Partials       31       31           

Files with missing lines	Coverage Δ
engine/text.go	97.94% <100.00%> (+0.01%)	⬆️

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c4c18d4 and c76b372.

📒 Files selected for processing (1)

• engine/text.go (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

engine/text.go (1)

196-204: Change correctly prevents recursive file loading

The updated code effectively prevents recursive loading by marking the file as loaded before compilation starts and unmarking it if compilation fails. This aligns with the objectives stated in the PR and linked issues.

[amimart]

👍