Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduction Rule #995

Merged
merged 30 commits into from
Dec 13, 2023
Merged

Reduction Rule #995

merged 30 commits into from
Dec 13, 2023

Conversation

HoshinoTented
Copy link
Contributor

@HoshinoTented HoshinoTented commented Sep 21, 2023

TODO List:

  • FnShape and matcher
  • Reduction rule
  • Fix bugs
  • Close this PR, and rePR them in several small PRs.

@HoshinoTented HoshinoTented added this to the v0.30 milestone Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (76775f6) 81.85% compared to head (9a364e9) 81.42%.
Report is 9 commits behind head on main.

Files Patch % Lines
...se/src/main/java/org/aya/core/term/IntegerOps.java 33.33% 17 Missing and 3 partials ⚠️
.../src/main/java/org/aya/tyck/repr/ShapeFactory.java 23.52% 13 Missing ⚠️
base/src/main/java/org/aya/tyck/ExprTycker.java 66.66% 3 Missing and 6 partials ⚠️
...e/src/main/java/org/aya/core/term/RuleReducer.java 46.66% 7 Missing and 1 partial ⚠️
...e/src/main/java/org/aya/core/term/IntegerTerm.java 66.66% 4 Missing and 2 partials ⚠️
base/src/main/java/org/aya/core/serde/SerTerm.java 61.53% 5 Missing ⚠️
...e/src/main/java/org/aya/core/serde/Serializer.java 76.19% 4 Missing and 1 partial ⚠️
base/src/main/java/org/aya/core/serde/SerDef.java 20.00% 4 Missing ⚠️
base/src/main/java/org/aya/terck/CallResolver.java 78.94% 1 Missing and 3 partials ⚠️
...c/main/java/org/aya/tyck/unify/TermComparator.java 76.92% 2 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #995      +/-   ##
============================================
- Coverage     81.85%   81.42%   -0.44%     
- Complexity     3441     3462      +21     
============================================
  Files           287      291       +4     
  Lines         10638    10789     +151     
  Branches       1284     1325      +41     
============================================
+ Hits           8708     8785      +77     
- Misses         1207     1271      +64     
- Partials        723      733      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HoshinoTented HoshinoTented force-pushed the fn-shape branch 2 times, most recently from b981bf8 to 6e92f62 Compare October 21, 2023 09:20
@HoshinoTented HoshinoTented changed the title Function Shape and reduction rule for them Reduction Rule Dec 12, 2023
ice1000 and others added 4 commits December 12, 2023 18:40
Co-authored-by: Hoshino Tented <hoshinotented@qq.com>
Co-authored-by: Hoshino Tented <hoshinotented@qq.com>
Co-authored-by: Hoshino Tented <hoshinotented@qq.com>
@ice1000 ice1000 marked this pull request as ready for review December 13, 2023 00:02
@ice1000 ice1000 added normalization Normalizer, JIT-compiled reduction, etc. core: definitions shape labels Dec 13, 2023
@ice1000 ice1000 merged commit cd88eeb into main Dec 13, 2023
4 of 6 checks passed
@ice1000 ice1000 deleted the fn-shape branch December 13, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core: definitions normalization Normalizer, JIT-compiled reduction, etc. shape
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants