Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary package installation info for debian based distro #172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bboyleonp666
Copy link

bpf-linker installation on debian distro requires additional packages, which only updated in https://github.com/aya-rs/bpf-linker yet to the book.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for aya-rs ready!

Name Link
🔨 Latest commit ca16942
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs/deploys/674cc0edf25cbc000841683b
😎 Deploy Preview https://deploy-preview-172--aya-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bboyleonp666
Copy link
Author

#100

@bboyleonp666 bboyleonp666 force-pushed the bpf-install-info-update branch from de03338 to 90e7e82 Compare October 18, 2024 15:54
@vadorovsky
Copy link
Member

@bboyleonp666 Thanks for your contribution! Can you rebase?

After rebase, I'm expecting markdownlint to complain about the length of lines, so please fix accordingly. 🙂

@bboyleonp666
Copy link
Author

bboyleonp666 commented Nov 22, 2024

@vadorovsky, thanks for considering this PR.
It seems weird that the build CI action is not triggered for this PR. I thought it could cause by the branch merge, so I push another commit, and it's still not triggered. Should we take a look at what's going on? Or should I just limit the line length and push a new commit for this one?

@vadorovsky
Copy link
Member

The CI builds for new contributors have to be approved by a maintainer. I've just done it and there is a build error.

Could you also remove the "merge" commit and do a rebase instead?

bpf-linker installation on debian distro requires additional
packages, which only updated in https://github.com/aya-rs/bpf-linker
yet to the book.
@bboyleonp666 bboyleonp666 force-pushed the bpf-install-info-update branch from a9acb9e to 46a9a66 Compare November 30, 2024 07:02
@bboyleonp666
Copy link
Author

@vadorovsky Done! I have rebased the commits and force-pushed a newer version. If I do it wrongly, please kindly let me know.

@bboyleonp666
Copy link
Author

@vadorovsky should I do some further steps to get this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants