Skip to content
This repository has been archived by the owner on Feb 3, 2024. It is now read-only.

Commit

Permalink
undo change to resolution exception behavior
Browse files Browse the repository at this point in the history
  • Loading branch information
ayan4m1 committed Oct 2, 2016
1 parent ad3d4ef commit 97c4bfe
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions GUI/MainModList.cs
Original file line number Diff line number Diff line change
Expand Up @@ -370,13 +370,7 @@ public async Task<IEnumerable<ModChange>> ComputeChangeSetFromModList(
var options = new RelationshipResolverOptions
{
without_toomanyprovides_kraken = false,
with_recommends = false,
//See #1371
//The code inside the while loop is only responsible for handling tmp resolution
//Inconsistencies are handled later,
//and this options are also disabled there
procede_with_inconsistencies = true,
without_enforce_consistency = true
with_recommends = false
};

foreach (var change in changeSet)
Expand All @@ -401,7 +395,6 @@ public async Task<IEnumerable<ModChange>> ComputeChangeSetFromModList(
var installed_modules =
registry.InstalledModules.Select(imod => imod.Module).ToDictionary(mod => mod.identifier, mod => mod);


bool handled_all_to_many_provides = false;
while (!handled_all_to_many_provides)
{
Expand Down Expand Up @@ -437,14 +430,14 @@ public async Task<IEnumerable<ModChange>> ComputeChangeSetFromModList(
}
}


foreach (var dependency in registry.FindReverseDependencies(modules_to_remove.Select(mod=>mod.identifier)))
{
//TODO This would be a good place to have a event that alters the row's graphics to show it will be removed
CkanModule module_by_version = registry.GetModuleByVersion(installed_modules[dependency].identifier,
installed_modules[dependency].version) ?? registry.InstalledModule(dependency).Module;
changeSet.Add(new ModChange(new GUIMod(module_by_version, registry, version), GUIModChangeType.Remove, null));
}

//May throw InconsistentKraken
//We want to allow InconstistencyKraken's
//Because we use them to check if something conflicts
Expand Down

0 comments on commit 97c4bfe

Please sign in to comment.