Skip to content
This repository has been archived by the owner on Aug 31, 2018. It is now read-only.

worker: implement vm.moveMessagePortToContext() #111

Closed
wants to merge 1 commit into from
Closed

worker: implement vm.moveMessagePortToContext() #111

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Contributor

This should help a lot with actual sandboxing of JS code.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added (later/other PR)
  • commit message follows commit guidelines
Affected core subsystem(s)

worker

@ghost
Copy link

ghost commented Oct 20, 2017

this is dependent on the main workers PR, which is why CI is failing, right?

@addaleax
Copy link
Contributor Author

It’s not really dependent but a small bit of the build config changes would conflict if I didn’t align it with the main workers PR, yes

@TimothyGu
Copy link
Member

Missing documentation.

@addaleax
Copy link
Contributor Author

https://github.com/ayojs/ayo/pull/112/files#diff-060f40e7d677d8184f81dad0dde7e7ecR313 :)

TimothyGu
TimothyGu approved these changes Oct 21, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the move of EventEmitter to extras could be applied with this PR.

addaleax added a commit that referenced this pull request Oct 22, 2017
@addaleax
worker: implement vm.moveMessagePortToContext()
36a21dd 
This should help a lot with actual sandboxing of JS code.

PR-URL: #111
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@addaleax
worker: implement vm.moveMessagePortToContext()
8579037 
This should help a lot with actual sandboxing of JS code.

PR-URL: #111
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@addaleax
Copy link
Contributor Author

Landed in 3ddde2c 🎉

@addaleax addaleax closed this Oct 24, 2017
addaleax added a commit that referenced this pull request Oct 24, 2017
@addaleax
worker: implement vm.moveMessagePortToContext()
3ddde2c 
This should help a lot with actual sandboxing of JS code.

PR-URL: #111
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@addaleax addaleax deleted the move-to-context branch October 24, 2017 21:52
addaleax added a commit to addaleax/node that referenced this pull request May 18, 2018
@addaleax
worker: implement vm.moveMessagePortToContext()
92bcd19 
This should help a lot with actual sandboxing of JS code.

Thanks to Timothy Gu, Stephen Belanger and Benjamin Gruenbaum
for reviewing this change in its original form.

Refs: ayojs/ayo#111
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
semver-minor vm worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @TimothyGu @Qard @benjamingr