Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot API 8.1 #239

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Bot API 8.1 #239

merged 3 commits into from
Dec 7, 2024

Conversation

ayrat555
Copy link
Owner

@ayrat555 ayrat555 commented Dec 6, 2024

@ayrat555 ayrat555 requested review from EdJoPaTo and pxp9 December 6, 2024 15:48
Copy link
Collaborator

@EdJoPaTo EdJoPaTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only looked at the code, not at the changes, so take it with a grain of salt.

pub amount: u32,
pub nanostar_amount: Option<u32>,
}

#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
#[serde(tag = "type", rename_all = "snake_case")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like this could be marked as non_exhaustive… on the other hand, its a breaking change on a breaking release, so it might be more helpful to get the actual change for people to adapt to the new case rather to not notice the new case on the (breaking) update

@ayrat555 ayrat555 merged commit e9a799f into master Dec 7, 2024
58 checks passed
@ayrat555 ayrat555 deleted the ayrat555/telegram-bot-api-8.1 branch December 7, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants