Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1016: Convert build scripts to ESM. #1036

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Closes #1016: Convert build scripts to ESM. #1036

merged 7 commits into from
Jan 12, 2024

Conversation

mmunro-ltrr
Copy link
Member

Follow upstream Bootstrap in using the currently favored ESM JavaScript module system, without which future updates to the dev dependencies may break.

@mmunro-ltrr mmunro-ltrr added dependencies Pull requests that update a dependency file ci Continuous integration / automation labels Nov 17, 2023
@mmunro-ltrr mmunro-ltrr requested a review from a team November 17, 2023 22:33
@mmunro-ltrr mmunro-ltrr self-assigned this Nov 17, 2023
trackleft
trackleft previously approved these changes Nov 17, 2023
Copy link
Member

@trackleft trackleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice! I was able to build locally, and the Github actions also appear successful.

trackleft
trackleft previously approved these changes Dec 1, 2023
@trackleft trackleft merged commit d8b42ab into main Jan 12, 2024
2 checks passed
@trackleft trackleft deleted the issue/1016 branch January 12, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration / automation dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream Bootstrap's development and CI JavaScript tools now prefer ESM modules.
3 participants