Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recording mic when should not #130

Closed
aza547 opened this issue Sep 20, 2022 · 6 comments · Fixed by #133
Closed

Recording mic when should not #130

aza547 opened this issue Sep 20, 2022 · 6 comments · Fixed by #133
Labels
bug Something isn't working

Comments

@aza547
Copy link
Owner

aza547 commented Sep 20, 2022

Describe the bug

Hey al so im having an issue where the recorder is recording my microphone even though ive diabled it in the settings
i believe i did that right unfortunately i deleted the old videos themselves so if i need to i can return to it later and post fresh logs

WarcraftRecorder-2022-09-19 (10).log
2022-09-19_11-31-33.txt

Expected behavior
When configuring no audio input, none should record.

[2022-09-19 11:13:00.539] [info]  [Main] Got from config store:  audio-input-device undefined
[2022-09-19 11:13:00.540] [info]  [Main] Got from config store:  audio-output-device undefined

[2022-09-19 11:28:09.524] [debug] [OBS] OBS: setSetting Output Track2Name Microphone (Logitech G933 Gaming Headset)
[2022-09-19 11:28:09.526] [info]  [OBS] Selecting audio input device: Microphone (Logitech G933 Gaming Headset) 
[2022-09-19 11:28:09.527] [debug] [OBS] OBS: setSetting Output Track3Name Microphone (HD Pro Webcam C920)
[2022-09-19 11:28:09.529] [info]  [OBS] Selecting audio input device: Microphone (HD Pro Webcam C920) 
[2022-09-19 11:28:09.532] [debug] [OBS] OBS: setSetting Output Track4Name Speakers (Logitech G933 Gaming Headset)
[2022-09-19 11:28:09.534] [info]  [OBS] Selecting audio output device: Speakers (Logitech G933 Gaming Headset) 
[2022-09-19 11:28:09.538] [debug] [OBS] OBS: setSetting Output Track5Name XF273 S (2- NVIDIA High Definition Audio)
@aza547 aza547 added the bug Something isn't working label Sep 20, 2022
@aza547
Copy link
Owner Author

aza547 commented Sep 20, 2022

Broken log:
[2022-09-19 11:28:04.525] [info] [Main] Got from config store: audio-input-device undefined
[2022-09-19 11:28:04.526] [info] [Main] Got from config store: audio-output-device undefined

My log:
[2022-09-20 21:04:09.352] [info] [Main] Got from config store: audio-input-device none
[2022-09-20 21:04:09.353] [info] [Main] Got from config store: audio-output-device none

@aza547
Copy link
Owner Author

aza547 commented Sep 20, 2022

Maybe a first time setup thing if user didn't explicitly set the fields to none?

@aza547
Copy link
Owner Author

aza547 commented Sep 20, 2022

Reproduced this by:

  1. Delete config.json.
  2. Launch app, fill out settings, don't touch audio fields.
  3. Settings save without the fields (so they end up undefined).
  4. Changing the fields to all, saving, then changing back to none, saving -- they end up set to none and are handled correctly.

@aza547
Copy link
Owner Author

aza547 commented Sep 20, 2022

@tdaugaard mind taking a look at this one as I think you know the code

@tdaugaard
Copy link
Contributor

tdaugaard commented Sep 20, 2022 •
edited
Loading

Maybe a first time setup thing if user didn't explicitly set the fields to none?

I'm quite certain the app sets 'all' as default, but I might have done it wrong, I'll check it out.

tdaugaard added a commit to tdaugaard/wow-recorder that referenced this issue Sep 20, 2022
@tdaugaard
Fix invalid default audio device
819d8d8 
Because the settings weren't initially set and the default value wasn't
applied, `audioInputDevice` and `audioOutputDevice` ended up being
`undefined` which caused it to _show_ them as being 'None', but in fact
acted as if it was set to 'All'.

Fixes aza547#130
tdaugaard added a commit to tdaugaard/wow-recorder that referenced this issue Sep 20, 2022
@tdaugaard
Fix invalid default audio device
e4a3737 
Because the settings weren't initially set and the default value wasn't
applied, `audioInputDevice` and `audioOutputDevice` ended up being
`undefined` which caused it to _show_ them as being 'None', but in fact
acted as if it was set to 'All'.

Fixes aza547#130
tdaugaard added a commit to tdaugaard/wow-recorder that referenced this issue Sep 20, 2022
@tdaugaard
Fix invalid default audio device
110ef12 
Because the settings weren't initially set and the default value wasn't
applied, `audioInputDevice` and `audioOutputDevice` ended up being
`undefined` which caused it to _show_ them as being 'None', but in fact
acted as if it was set to 'All'.

Fixes aza547#130
@tdaugaard tdaugaard mentioned this issue Sep 20, 2022
Merged
@tdaugaard
Copy link
Contributor

I had done it wrong. 😬 I have done it right, now.

tdaugaard added a commit to tdaugaard/wow-recorder that referenced this issue Sep 21, 2022
@tdaugaard
Fix invalid default audio device
57870ac 
Because the settings weren't initially set and the default value wasn't
applied, `audioInputDevice` and `audioOutputDevice` ended up being
`undefined` which caused it to _show_ them as being 'None', but in fact
acted as if it was set to 'All'.

Fixes aza547#130
tdaugaard added a commit to tdaugaard/wow-recorder that referenced this issue Sep 21, 2022
@tdaugaard
Fix invalid default audio device
668d3d7 
Because the settings weren't initially set and the default value wasn't
applied, `audioInputDevice` and `audioOutputDevice` ended up being
`undefined` which caused it to _show_ them as being 'None', but in fact
acted as if it was set to 'All'.

Fixes aza547#130
aza547 pushed a commit that referenced this issue Sep 21, 2022
@tdaugaard
Fix invalid default audio device (#133)
86fd70e 
* Fix invalid default audio device

Because the settings weren't initially set and the default value wasn't
applied, `audioInputDevice` and `audioOutputDevice` ended up being
`undefined` which caused it to _show_ them as being 'None', but in fact
acted as if it was set to 'All'.

Fixes #130

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid default audio device tdaugaard/wow-recorder
2 participants
@tdaugaard @aza547