Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a version check #74

Closed
aza547 opened this issue Sep 4, 2022 · 4 comments
Closed

Add a version check #74

aza547 opened this issue Sep 4, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@aza547
Copy link
Owner

aza547 commented Sep 4, 2022

Something we discussed, a link back to GitHub to check for new versions and display if an upgrade is available would be nice.

Crucially it shouldn't be obnoxious, and should be easily dismissed if a user doesn't want to upgrade.
@aza547 aza547 added the enhancement New feature or request label Sep 4, 2022
@aza547
Copy link
Owner Author

aza547 commented Sep 4, 2022

While in the area it would also be good to log the version, we don't do that currently.

@tdaugaard
Copy link
Contributor

Perhaps take a look electron-builder https://www.electron.build/, which has an Auto Update feature if that's something you're interested in.

@aza547
Copy link
Owner Author

aza547 commented Sep 18, 2022

being handled here #102

@aza547
Copy link
Owner Author

aza547 commented Sep 18, 2022

Actually that's just the adding of a version number to logs / title. We still want a check to confirm it's the latest.

NickIs211 added a commit to NickIs211/wow-recorder that referenced this issue Sep 18, 2022
@NickIs211
Added changelog Line for aza547#74
15645b1
@NickIs211 NickIs211 mentioned this issue Sep 18, 2022
Merged
NickIs211 added a commit to NickIs211/wow-recorder that referenced this issue Sep 18, 2022
@NickIs211
Added changelog Line for aza547#74
e013a7f
aza547 pushed a commit that referenced this issue Sep 18, 2022
@NickIs211
Feature check updates (#114)
fcf196d 
* added release tracking

* Added changelog Line for #74

* Updated comment lost on rebase

* fixed a few lint errors

* changes from pr #114

* Added 200 check

* not null check
@aza547 aza547 closed this as completed Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdaugaard @aza547